PHP Experts, Optimization question

[Brujah]

Looking to optimize a lengthy switch/case statement. Working on something like this, and considering how to optimize it and speed it up. It's not that slow yet but it might be when it's finished.

switch($var) {
  case 'val1':
      $action = 'step1';  break;
 case 'val2':
      $action = 'step2';  break;

 .. and so on for about 200 more of these ..

 default:
      $action = 'do the hokey pokey';  break;
}

[Echo]

if your $action are text/word try to put them in array() or store them in your database and call it in a limited query output

[paterson3713]

Yeah you could do like:

$actions['val1'] = 'step1';
$actions['val2'] = 'step2';

// Then, 
$action = $actions[$var];

Or, like it was also mentioned before, using a database:

// First, put the values into a mysql database like: value | action
// Then,
$action = @mysql_result(mysql_query('SELECT action FROM mySteps WHERE value=\''.mysql_escape_string($var).'\''),0);

[s9ann0]

fuck that get your host to install a PHP cache!

[mrkris]

Yeah you could do like:

$actions['val1'] = 'step1';
$actions['val2'] = 'step2';

// Then, 
$action = $actions[$var];

Or, like it was also mentioned before, using a database:

// First, put the values into a mysql database like: value | action
// Then,
$action = @mysql_result(mysql_query('SELECT action FROM mySteps WHERE value=\''.mysql_escape_string($var).'\''),0);

Never mix storage with procedure. The easiest thing to do, would be something like:

$method = 'some' . $action;
if (method_exists(array(&$object, $method))) {
$function->$method;
}

I would do something like that ...