php question

[mkx]

I am new to php and am working on a script to show search results. I am getting the following error with this and was wondering if I am doing something wrong or have the wrong version of php on my server because I am copying this code directly from php5 and mysql4 for dummies and have php4 on my server:

<?php

$user = "user";
$host = "localhost";
$password = "pass";
$database = "database";

$connection = mysql_connect($host,$user,$password)
or die ("Couldn't connect to server");
$db = mysql_select_db($database,$connection)
or die ("Couldn't select database");

$query = "SELECT * FROM `features`";
$result = mysql_query($query)
or die ("Couldn't execute query.");

/* Dsiplay results in a table */

echo "<table cellspacing='10' border=0' cellpadding='0' width='100%'?";
echo "<tr><td colspan='5' align='right'>Click on any picture to see a larger version.<br><hr></td></tr>\n;

while ($row = mysql_fetch_array{result,MYSQL_ASSOC))
{

/* display row for each listingid */
echo "<tr>\n;
echo "<td>{$row['intersection1']}</td>\n";
?>



I get his error:


Parse error: parse error, unexpected '>' in /public_html/pa/index.php on line 26

[arnette]

you need a " at the end of your echo

[arnette]

twice

...

[woj]

change this:
echo "<tr><td colspan='5' align='right'>Click on any picture to see a larger version.<br><hr></td></tr>\n;

to:
echo "<tr><td colspan='5' align='right'>Click on any picture to see a larger version.<br><hr></td></tr>\n";

in case it wasn't obvious what arnette said...

[arnette]

change this:
echo "<tr><td colspan='5' align='right'>Click on any picture to see a larger version.<br><hr></td></tr>\n;

to:
echo "<tr><td colspan='5' align='right'>Click on any picture to see a larger version.<br><hr></td></tr>\n";

in case it wasn't obvious what arnette said...

this one too

echo "<tr>\n;

to:
echo "<tr>\n";

[V_RocKs]

No you didn't close the loop with a }

[V_RocKs]

Also, this is better written from,

echo "<td>{$row['intersection1']}</td>\n";

to

echo "<td>".$row['intersection1']."</td>\n";

And when you post code here, use code tags or we might not see what you typed.

[Alky]

Also, this is better written from,

echo "<td>{$row['intersection1']}</td>\n";

to

echo "<td>".$row['intersection1']."</td>\n";

And when you post code here, use code tags or we might not see what you typed.

you edit fast, i was about to call you on your error

[mkx]

Still shows same error after changing to:

/* display row for each listingid */
echo "<tr>\n";
echo "<td>{$row['intersection1']}</td>\n";
?>

[Alky]

Still shows same error after changing to:

/* display row for each listingid */
echo "<tr>\n";
echo "<td>{$row['intersection1']}</td>\n";
?>

you need to close your while loop

put a } before the ?>

[Alky]

also
while ($row = mysql_fetch_array{result,MYSQL_ASSOC)) is wrong,

it should be
while ($row = mysql_fetch_array($result,MYSQL_ASSOC))

[mkx]

Ok changed to:

/* Dsiplay results in a table */

echo "<table cellspacing='10' border=0' cellpadding='0' width='100%'?";
echo "<tr><td colspan='5' align='right'>Click on any picture to see a larger version.<br><hr></td></tr>\n";

while ($row = mysql_fetch_array{result,MYSQL_ASSOC))


/* display row for each listingid */
echo "<tr>\n";
echo "<td>".$row['intersection1']."</td>\n";
?>

Now I get this error:


Parse error: parse error, unexpected '{' in /public_html/pa/index.php on line 22

[Alky]

you didnt copy this code very well...

[mkx]

also
while ($row = mysql_fetch_array{result,MYSQL_ASSOC)) is wrong,

it should be
while ($row = mysql_fetch_array($result,MYSQL_ASSOC))

problem solved. Thanks!

[Zester]

found a few too:

echo "<table cellspacing='10' border=0' cellpadding='0' width='100%'?";

look at the "border" part, its missing a '
also the "?" at the end of it should be a ">" instead

e.g:

echo "<table cellspacing='10' border='0' cellpadding='0' width='100%'>";

[V_RocKs]

Did you END the loop?

while ($row = mysql_fetch_array{result,MYSQL_ASSOC))
{

/* display row for each listingid */
echo "<tr>\n;
echo "<td>{$row['intersection1']}</td>\n";
}

Notice the }

[Alky]

man your screwing it all up ... now you need a { after your while statement

[mkx]

you didnt copy this code very well...

Nope, for a second there I thought php for dummies was for dummies but now I realize I am the dummy. Thanks for everyones help

[Zester]

wow you guys are fast posters

[Alky]

e.g:

echo "<table cellspacing='10' border='0' cellpadding='0' width='100%'>";

html with ' is ugly

[mkx]

Added the loop, Even better, Thanks!

[V_RocKs]

Not to mention, mysql_assoc_array($result)
would work for that section too.

[V_RocKs]

man your screwing it all up ... now you need a { after your while statement

haha.. touche... }

[mkx]

One more quicky, how do I make it display Intersection1 & Intersection2 such as "Street1 & Street2" in the line :

echo "<td>".$row['intersection1']."</td>\n";

[Alky]

Ok changed to:

/* Dsiplay results in a table */

echo "<table cellspacing='10' border=0' cellpadding='0' width='100%'?";
echo "<tr><td colspan='5' align='right'>Click on any picture to see a larger version.<br><hr></td></tr>\n";

while ($row = mysql_fetch_array{result,MYSQL_ASSOC))


/* display row for each listingid */
echo "<tr>\n";
echo "<td>".$row['intersection1']."</td>\n";
?>

haha.. touche... }

i was going from that ;)

[Alky]

One more quicky, how do I make it display Intersection1 & Intersection2 such as "Street1 & Street2" in the line :

echo "<td>".$row['intersection1']."</td>\n";

echo "<td>".$row['intersection1'].$row['intersection2']."</td>\n";

[mkx]

Thanks again!

[over911]

Didnt know ya were into PHP V!

Nice