Quick PHP Question

[mkx]

I am new to PHP and trying to insert information into a table automatically by going to a URL. For example. I want it so when I go to www.url.com?user=test&password=word

it will automatically add the user name and password into the table (users)

I tried using the following for www.url.com/index.php

<?

$DBhost = "localhost";
$DBuser = "userdb";
$DBpass = "password";
$DBName = "namedb";

mysql_connect($DBhost,$DBuser,$DBpass) or die("Unable to connect to database");

@mysql_select_db("$DBName") or die("Unable to select
database $DBName");


mysql_query("INSERT INTO `Users` VALUES ('$user','$password')") or die(mysql_error());


mysql_close();

?>

This brings me to a blank page but does not add anything to the table


Is there something I might be doing wrong?

[mkx]

Nevermind, its working now ;)

[Repetitive Monkey]

Sloppy! ;) Here's how I would have done it.

<?
$DBhost="localhost";
$DBuser="userdb";
$DBpass="password";
$DBName="namedb";
if(@mysql_connect($DBhost,$DBuser,$DBpass)){
    if(@mysql_select_db($DBName)){
        if(!@mysql_query("INSERT INTO 'Users' VALUES ('".$_GET["user"]."','".$_GET["password"]."')")){
        echo"Unable to insert new row into table on the database <i>".$DBName."</i>.";
        }
    }else{
    echo"Unable to select the database <i>".$DBName."</i>.";
    }
@mysql_close();
}else{
echo"Unable to connect to MySQL.";
}
?>

[Repetitive Monkey]

Actually, you might also want to check for whether the required variables really exist, and some memory can also be saved on the internal variables. Please use this:

<?
if($_GET["user"] && $_GET["password"]){
    if(@mysql_connect("localhost","userdb","password")){
    $DBName="namedb";
        if(@mysql_select_db($DBName)){
            if(!@mysql_query("INSERT INTO `Users` VALUES ('".$_GET["user"]."','".$_GET["password"]."')")){
            echo"Unable to insert new row into the database <i>".$DBName."</i>.";
            }
        }else{
        echo"Unable to select the database <i>".$DBName."</i>.";
        }
    @mysql_close();
    }else{
    echo"Unable to connect to MySQL.";
    }
}else{
echo"Required variables are missing.";
}
?>

Replace the hahaha123; stuff with a right bracket.