PHP Experts, Optimization question - GoFuckYourself.com

Brujah · 03-17-2006, 08:33 AM

Looking to optimize a lengthy switch/case statement. Working on something like this, and considering how to optimize it and speed it up. It's not that slow yet but it might be when it's finished.

Code:

switch($var) {
  case 'val1':
      $action = 'step1';  break;
 case 'val2':
      $action = 'step2';  break;

 .. and so on for about 200 more of these ..

 default:
      $action = 'do the hokey pokey';  break;
}

Echo · 03-17-2006, 09:49 AM

if your $action are text/word try to put them in array() or store them in your database and call it in a limited query output

paterson3713 · 03-17-2006, 10:15 AM

Yeah you could do like:

Code:

$actions['val1'] = 'step1';
$actions['val2'] = 'step2';

// Then, 
$action = $actions[$var];

Or, like it was also mentioned before, using a database:

Code:

// First, put the values into a mysql database like: value | action
// Then,
$action = @mysql_result(mysql_query('SELECT action FROM mySteps WHERE value=\''.mysql_escape_string($var).'\''),0);

s9ann0 · 03-17-2006, 10:53 AM

fuck that get your host to install a PHP cache!

mrkris · 03-17-2006, 11:08 AM

Quote:

Originally Posted by paterson3713

Yeah you could do like:

Code:

$actions['val1'] = 'step1';
$actions['val2'] = 'step2';

// Then, 
$action = $actions[$var];

Or, like it was also mentioned before, using a database:

Code:

// First, put the values into a mysql database like: value | action
// Then,
$action = @mysql_result(mysql_query('SELECT action FROM mySteps WHERE value=\''.mysql_escape_string($var).'\''),0);

Never mix storage with procedure. The easiest thing to do, would be something like:

$method = 'some' . $action;
if (method_exists(array(&$object, $method))) {
$function->$method;
}

I would do something like that ...

03-17-2006, 08:33 AM	#1
Brujah Beer Money Baron Industry Role: Join Date: Jan 2001 Location: brujah / gmail Posts: 22,157	PHP Experts, Optimization question Looking to optimize a lengthy switch/case statement. Working on something like this, and considering how to optimize it and speed it up. It's not that slow yet but it might be when it's finished. Code: switch($var) { case 'val1': $action = 'step1'; break; case 'val2': $action = 'step2'; break; .. and so on for about 200 more of these .. default: $action = 'do the hokey pokey'; break; } __________________ Free Premium Domain Lists and Tools at Clickmojo.com For Sale: Obscenity.com

03-17-2006, 09:49 AM	#2
Echo Confirmed User Join Date: Nov 2003 Posts: 158	if your $action are text/word try to put them in array() or store them in your database and call it in a limited query output __________________ ICQ #228-338-185

03-17-2006, 10:53 AM	#4
s9ann0 Confirmed User Join Date: Sep 2001 Location: Boston Posts: 4,873	fuck that get your host to install a PHP cache!