php changed my life - GoFuckYourself.com

JamesK · 11-03-2003, 08:43 AM

<?php

$noheader=1;

//require("./global.php");

set_magic_quotes_runtime(0);

error_reporting(7);

// ###################### Start init #######################

unset($dbservertype);
unset($debug);

//load config
require('./admin/config.php');
if ($debug != 1) {
unset($showqueries);
unset($explain);
}

// init db **********************
// load db class
$dbservertype = strtolower($dbservertype);
$dbclassname="./admin/db_$dbservertype.php";
require($dbclassname);

$DB_site=new DB_Sql_vb;

$DB_site->appname='vBulletin';
$DB_site->appshortname='vBulletin (forum)';
$DB_site->database=$dbname;
$DB_site->server=$servername;
$DB_site->user=$dbusername;
$DB_site->password=$dbpassword;

$DB_site->connect();

$dbpassword="";
$DB_site->password="";
// end init db

if (!empty($userid)) {
$userid = intval($userid);
} else if (!empty($HTTP_POST_VARS['userid'])) {
$userid = intval($HTTP_POST_VARS['userid']);
} else if (!empty($HTTP_GET_VARS['userid'])) {
$userid = intval($HTTP_GET_VARS['userid']);
} else {
$userid = 0;
}

if ($avatarinfo=$DB_site->query_first("SELECT avatardata,dateline,f

Poo-Chee · 11-03-2003, 08:45 AM

very compact life...

Fonz · 11-03-2003, 08:51 AM

don't see how you can order a beer at the bar with that

SMG · 11-03-2003, 08:52 AM

JamesK · 11-03-2003, 08:57 AM

Quote:

Originally posted by SMG
O_o

well said

DarkJedi · 11-03-2003, 08:59 AM

OMG !!

what is that btw ?

Poo-Chee · 11-03-2003, 09:05 AM

Quote:

Originally posted by DarkJedi
OMG !!

what is that btw ?

php

who · 11-03-2003, 09:28 AM

Quote:

Originally posted by Poo-Chee

php

WOW! That's space age shit!!!!!!!!!!!!!!

TheFLY · 11-03-2003, 10:07 AM

I've coded some PHP and I have no idea WTF that does... add some comments... :p

DarkJedi · 11-03-2003, 10:14 AM

yes, what does it do ?

badmrfrosty · 11-03-2003, 10:16 AM

maybe the reason you dont know what it does is because it doesnt do anything

if ($avatarinfo=$DB_site->query_first("SELECT avatardata,dateline,f
because it isnt finished...

BMF

Nightwork · 11-03-2003, 10:19 AM

what's the most "practical" programming language to know for the web?

When I was talking about bad programming in the topic above, I referred to trash like this, hehe

JamesK · 11-03-2003, 10:20 AM

Quote:

Originally posted by Nightwork
what's the most "practical" programming language to know for the web?

When I was talking about bad programming in the topic above, I referred to trash like this, hehe

how the fuck can you call it trash? I took it from VBulletin, one of the best community scripts ever.

badmrfrosty · 11-03-2003, 10:31 AM

vbulletin is the most insecure xss prone script next to phpnuke ;-)

yeah its reaaaaaal good, 80% of good hosting compaines will not run vbulletin or phpnuke on their servers because it is nefarious for being shit.

BMF

TheViper · 11-03-2003, 10:31 AM

Quote:

Originally posted by Wildcard

how the fuck can you call it trash? I took it from VBulletin, one of the best community scripts ever.

TRASH

Nightwork · 11-03-2003, 10:39 AM

Quote:

how the fuck can you call it trash? I took it from VBulletin, one of the best community scripts ever.

Ok than...
First off, it's uncommented. Scripts without proper comments suck by default.

The structure is trash. You put includes/requires on top not in the middle of your source. It's all about structure

The dbase class (and I even haven't seen it completly)is crap.

stuff like:
$dbservertype = strtolower($dbservertype);
$dbclassname="./admin/db_$dbservertype.php";

Are solutions you use when you start programming one month.
See adodb for how a good dbasewrappingclass looks like.

$DB_site->appname='vBulletin';
$DB_site->appshortname='vBulletin (forum)';
$DB_site->database=$dbname;
$DB_site->server=$servername;
$DB_site->user=$dbusername;
$DB_site->password=$dbpassword;

If you like to type a lot and do things double, go ahead. But this should be one line of code max).

if ($debug != 1) {
unset($showqueries);
unset($explain);
}

If you use debugging functionallity, write a global debugging function and put it in yr global/config file. And trigger it on seperate ages by simply adjusting a $debug to True or false;

Since PHP 4.0.x or something, global_vars are set off by default (for a very, very good security reason)

if (!empty($userid)) {
$userid = intval($userid);
} else if (!empty($HTTP_POST_VARS['userid'])) {
$userid = intval($HTTP_POST_VARS['userid']);
} else if (!empty($HTTP_GET_VARS['userid'])) {
$userid = intval($HTTP_GET_VARS['userid']);
} else {
$userid = 0;
}

ifelse loops like above are written by people who apparently have trouble understandig security issues and haven't made up their mind about what they're writing and what it should do in the first place.
Besides, you pass values like $userid through sessions not through forms.

So that's how the f*ck I call it trash

And yeah, I'm just bored, hehe

fris · 11-03-2003, 10:47 AM

WHILE ($answers < $solutions) {
echo "Not done yet";
$learn++;
}

sweet7 · 11-03-2003, 10:54 AM

Quote:

Originally posted by TheFLY
I've coded some PHP and I have no idea WTF that does... add some comments... :p

connects to some db's but the code gets cut off so who knows what happens during and after the query.

Looks like it might be a login script.
Needs comments.

KCat · 11-03-2003, 12:40 PM

Quote:

Originally posted by fris
WHILE ($answers < $solutions) {
echo "Not done yet";
$learn++;
}

TDF · 11-03-2003, 12:45 PM

geekie tech 101

11-03-2003, 08:43 AM	#1
JamesK hi Industry Role: Join Date: Jun 2002 Posts: 16,731	php changed my life <?php $noheader=1; //require("./global.php"); set_magic_quotes_runtime(0); error_reporting(7); // ###################### Start init ####################### unset($dbservertype); unset($debug); //load config require('./admin/config.php'); if ($debug != 1) { unset($showqueries); unset($explain); } // init db ********************** // load db class $dbservertype = strtolower($dbservertype); $dbclassname="./admin/db_$dbservertype.php"; require($dbclassname); $DB_site=new DB_Sql_vb; $DB_site->appname='vBulletin'; $DB_site->appshortname='vBulletin (forum)'; $DB_site->database=$dbname; $DB_site->server=$servername; $DB_site->user=$dbusername; $DB_site->password=$dbpassword; $DB_site->connect(); $dbpassword=""; $DB_site->password=""; // end init db if (!empty($userid)) { $userid = intval($userid); } else if (!empty($HTTP_POST_VARS['userid'])) { $userid = intval($HTTP_POST_VARS['userid']); } else if (!empty($HTTP_GET_VARS['userid'])) { $userid = intval($HTTP_GET_VARS['userid']); } else { $userid = 0; } if ($avatarinfo=$DB_site->query_first("SELECT avatardata,dateline,f __________________ M3Server - NATS Hosting

11-03-2003, 08:51 AM	#3
Fonz Confirmed User Industry Role: Join Date: Aug 2003 Location: Hellgium Posts: 486	don't see how you can order a beer at the bar with that __________________ hardlinks for sale - ICQ 24298240 - linksatsmilinpussy.com

11-03-2003, 08:52 AM	#4
SMG Confirmed User Join Date: Aug 2003 Posts: 1,798	O_o __________________ TGP Webmasters: sign up for the top 100 tgp list! Submit galleries If you add me to icq (title) make sure to mention GFY or I'll think you're a bot and deny you.

11-03-2003, 10:19 AM	#12
Nightwork Registered User Join Date: Oct 2003 Posts: 61	what's the most "practical" programming language to know for the web? When I was talking about bad programming in the topic above, I referred to trash like this, hehe __________________ God may have created the world in 6 days, but you can bet your ass that while he rested on the 7th, a programmer coded it all.<br>ICQ:48322442

11-03-2003, 10:47 AM	#17
fris Too lazy to set a custom title Industry Role: Join Date: Aug 2002 Posts: 55,571	WHILE ($answers < $solutions) { echo "Not done yet"; $learn++; } __________________ Since 1999: 69 Adult Industry awards for Best Hosting Company and professional excellence. My Cam Feeds Script / Gallery Scraper / WPXXX Theme / Free Templates

11-03-2003, 08:45 AM	#2
Poo-Chee So Fucking Banned Join Date: Sep 2003 Location: Rotterdam Posts: 3,560	very compact life...

11-03-2003, 08:59 AM	#6
DarkJedi No Refunds Issued. Industry Role: Join Date: Feb 2001 Location: GFY Posts: 28,301	OMG !! what is that btw ?

11-03-2003, 10:07 AM	#9
TheFLY So Fucking Banned Join Date: Jan 2001 Location: http://www.thefly.net/ --- Quit your job and live off steady traffic. Posts: 11,856	I've coded some PHP and I have no idea WTF that does... add some comments... :p

11-03-2003, 10:14 AM	#10
DarkJedi No Refunds Issued. Industry Role: Join Date: Feb 2001 Location: GFY Posts: 28,301	yes, what does it do ?

11-03-2003, 10:16 AM	#11
badmrfrosty Confirmed User Join Date: May 2003 Posts: 500	maybe the reason you dont know what it does is because it doesnt do anything if ($avatarinfo=$DB_site->query_first("SELECT avatardata,dateline,f because it isnt finished... BMF

11-03-2003, 10:31 AM	#14
badmrfrosty Confirmed User Join Date: May 2003 Posts: 500	vbulletin is the most insecure xss prone script next to phpnuke ;-) yeah its reaaaaaal good, 80% of good hosting compaines will not run vbulletin or phpnuke on their servers because it is nefarious for being shit. BMF

11-03-2003, 12:45 PM	#20
TDF Triple OG nigga on GFY Industry Role: Join Date: Mar 2002 Location: in the BP4L family compound Posts: 27,296	geekie tech 101 __________________ Sig heil