php redirect shows blank page

[klinton]

hey, i setup some php rotation redirect...It should redirects people to some url from list.

however i see now, that it returns blank page every now and then...and i had to refresh page to get redirection...why is that ?

[myneid]

thats kind of like saying that your car doesnt work whats wrong with it, without giving the specifics

[klinton]

<?php

$urls[] = "url1";
$urls[] = "url2";
$urls[] = "url3";
$urls[] = "url4";
$urls[] = "url5";

srand ((double) microtime( )*1000000);
$random = rand(0,count($urls));

header("location:" . $urls[$random]);
exit;
?>

it sometimes redirects&rotate url,sometimes just show blank page....

[Serge Litehead]

perhaps count($urls) needs -1
count($urls)-1

[Serge Litehead]

when debugging you can print out url and random number vars and see where problem lays

[myneid]

yea thats what it is you need count($urls)-1 because count returns the number of elements in teh array but the array is indexed starting at 0

[klinton]

so i should add this line somewhere :-P ???

count($urls)-1 ??

where ;-) ?

edit: ups now i see it...

THANKS !!!

[myneid]

actually i take that back, dont do the $count-1
instead cahnge this line to this
header("location:" . $urls[$random-1]);

[grumpy]

Originally Posted by myneid

actually i take that back, dont do the $count-1
instead cahnge this line to this
header("location:" . $urls[$random-1]);

nope, that can result in -1 your first suggestion was ok

replace
$random = rand(0,count($urls));
with
$random = rand(0,count($urls)-1);

[myneid]

ha! yea looks like the sudafed is affecting my judgement more than i previously thought

[grumpy]

Originally Posted by myneid

ha! yea looks like the sudafed is affecting my judgement more than i previously thought

i know exactly what you mean

[Tempest]

Originally Posted by grumpy

nope, that can result in -1 your first suggestion was ok

replace
$random = rand(0,count($urls));
with
$random = rand(0,count($urls)-1);

What he said...

[woj]

using array_rand is probably more straightforward...

[GrouchyAdmin]

Originally Posted by woj

using array_rand is probably more straightforward...

Certainly takes out some minor overhead by calling count() manually for each parse. I'd suggest this as well for something as simple-tarded as mentioned.

<?php
$urls = array(
        'http://www.google.com',
        'http://www.msn.com',
        'http://www.bing.com',
        'http://www.webcrawler.com',
        'http://www.dogpile.com',
);
header("location: ". array_rand(array_flip($urls), 1));
?>

[Tempest]

Originally Posted by GrouchyAdmin

Certainly takes out some minor overhead by calling count() manually for each parse. I'd suggest this as well for something as simple-tarded as mentioned.

<?php
$urls = array(
        'http://www.google.com',
        'http://www.msn.com',
        'http://www.bing.com',
        'http://www.webcrawler.com',
        'http://www.dogpile.com',
);
header("location: ". array_rand(array_flip($urls), 1));
?>

Or he could just do a shuffle.

<?php
$urls[] = "url1";
$urls[] = "url2";
$urls[] = "url3";
$urls[] = "url4";
$urls[] = "url5";

shuffle($urls);

header('location: '.$urls[0]);
?>

Gotta love how's there multiple solutions to the same thing.